-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support testing previous non-current .NETCoreApp targeted libraries #54639
Comments
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsFrom #54636 from @eerhardt
from @ericstj
The overall issue isn't specific to Windows, we need coverage on as many OSs that a library supports, as possible. The cost that I'm concerned about isn't observable in the amount of build agents but in the number of Helix clients that accept work items. I imagine support for testing on older .NETCoreApp configurations could be implemented in the following way in order:
|
from @safern:
Every OOB project that today targets $(NetCoreAppCurrent) will need to continue to test for net6.0 when we change main to target net7.0. Basically that means every OOB that isn't .NETFramework specific (95% of all OOBs).
That was my idea as well but ideally we would have a plan for the long run as well to be able to test for all compatible OSs, i.e. Browser as well. I'm fine with starting on build agents but is there a reason to not use Helix for it if it's just a nightly job? |
That's fine as well, however that would be yet another pipeline to take a look at. |
Also remove ProjectReferences which aren't necessary anymore as these references are part of the targeting pack now. This results in a reduced dependency graph and will make builds faster. Contributes to #54639
From #54636
from @eerhardt
from @ericstj
The overall issue isn't specific to Windows, we need coverage on as many OSs that a library supports, as possible. The cost that I'm concerned about isn't observable in the amount of build agents but in the number of Helix clients that accept work items.
I imagine support for testing on older .NETCoreApp configurations could be implemented in the following way in order:
$(NetCoreAppMinimum)
.NetCoreAppMinimum
/NetCoreAppPrevious
TFMs to the OOB test projects either everywhere or on a per project basis where it makes sense.The text was updated successfully, but these errors were encountered: