QUIC: ShutdownCompleted cancellation token does not actually cancel the call

[geoffkizer]

We register for cancellation here, but even if the registration fires, we don't actually do anything to cancel the ShutdownCompletionSource.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

We register for cancellation here, but even if the registration fires, we don't actually do anything to cancel the ShutdownCompletionSource.

Author:	geoffkizer
Assignees:	-
Labels:	area-System.Net.Quic
Milestone:	6.0.0

[CarnaViire]

You mean to let msquic know about that, i.e. to call for an immediate abortive shutdown?

Update:
Ah, I see, we touch on the wrong completion source here

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs

Lines 607 to 625 in 7cfa945

	using CancellationTokenRegistration registration = cancellationToken.UnsafeRegister(static (s, token) =>
	{
	var state = (State)s!;
	bool shouldComplete = false;
	lock (state)
	{
	if (state.ShutdownState == ShutdownState.None)
	{
	state.ShutdownState = ShutdownState.Canceled;
	shouldComplete = true;
	}
	}
	if (shouldComplete)
	{
	state.ShutdownWriteCompletionSource.SetException(
	ExceptionDispatchInfo.SetCurrentStackTrace(new OperationCanceledException("Wait for shutdown was canceled", token)));
	}
	}, _state);

This looks like a copy-paste bug, it should be ShutdownCompletionSource