-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_DataSentBeforeServerPreface_ProtocolError #56138
Labels
area-System.Net.Http
os-linux
Linux OS (any supported distro)
test-run-core
Test failures in .NET Core test runs
Milestone
Comments
dotnet-issue-labeler
bot
added
area-System.Net.Http
untriaged
New issue has not been triaged by the area owner
labels
Jul 22, 2021
Tagging subscribers to this area: @dotnet/ncl Issue DetailsTest failures 5/22-7/22 (incl. PRs):
|
cc @geoffkizer in case it is related to ConnectionPool changes ... |
karelz
added
os-linux
Linux OS (any supported distro)
and removed
untriaged
New issue has not been triaged by the area owner
labels
Jul 22, 2021
alnikola
added a commit
that referenced
this issue
Jul 30, 2021
In case of an error aborting the connection, there is a race between a thread creating new `Http2Stream` to send a request and the thread looping in `ProcessIncomingFrames` that sets _shutdown flag and `_abortException`. If the request thread first sees `_shutdown == true`, then it won't see the `_abortException` even if it's set, so the request will be retried when it shouldn't. This PR adds `_abortException` check just before the `_shutdown == true` check to make sure an abort exception is observed. Fixes #1581 Fixes #56138 Fixes #56026
ghost
locked as resolved and limited conversation to collaborators
Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Net.Http
os-linux
Linux OS (any supported distro)
test-run-core
Test failures in .NET Core test runs
Test failures 5/22-7/31 (incl. PRs):
Looks like increased frequency after Preview 7 cut off on 7/15 - perhaps some regression?
The text was updated successfully, but these errors were encountered: