Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most of Microsoft.Extensions.FileProviders.Physical should be supported on Browser #56178

Closed
eerhardt opened this issue Jul 22, 2021 · 2 comments · Fixed by #56189
Closed

Most of Microsoft.Extensions.FileProviders.Physical should be supported on Browser #56178

eerhardt opened this issue Jul 22, 2021 · 2 comments · Fixed by #56189
Assignees
@jozkee
Labels
area-Extensions-FileSystem untriaged New issue has not been triaged by the area owner

Comments

@eerhardt
Copy link
Member

eerhardt commented Jul 22, 2021 •
edited
Loading

Hosting uses PhysicalFileProvider, which is not supported on Browser. See #55664.

We should just mark the specific APIs that aren't supported on Browser instead of the whole assembly.

cc @SteveSandersonMS @pranavkm @Tratcher @davidfowl @jozkee
@ghost
Copy link

ghost commented Jul 22, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Hosting uses PhysicalFileProvider, which is not supported on Browser. See #55664.

We should just make Hosting not supported on Browser, since it is not used.

If we decide not to do this, we need to figure out what to do with the PhysicalFileProvider on Hosting when it is used on Browser.

cc @SteveSandersonMS @pranavkm @Tratcher @davidfowl

Author: eerhardt
Assignees: -
Labels:

area-Extensions-Hosting
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 22, 2021
eerhardt added a commit to eerhardt/runtime that referenced this issue Jul 22, 2021
@eerhardt
Fix build break
1b16b79 
Disable the warning until a proper fix can be made.

See dotnet#56178
@eerhardt eerhardt mentioned this issue Jul 22, 2021
Merged
@eerhardt eerhardt changed the title Disable Microsoft.Extensions.Hosting on Browser Most of Microsoft.Extensions.FileProviders.Physical should be supported on Browser Jul 22, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

Tagging subscribers to this area: @maryamariyan, @dotnet/area-extensions-filesystem
See info in area-owners.md if you want to be subscribed.

Issue Details

Hosting uses PhysicalFileProvider, which is not supported on Browser. See #55664.

We should just mark the specific APIs that aren't supported on Browser instead of the whole assembly.

cc @SteveSandersonMS @pranavkm @Tratcher @davidfowl @jozkee

Author: eerhardt
Assignees: -
Labels:

area-Extensions-FileSystem, untriaged
Milestone: -

stephentoub pushed a commit that referenced this issue Jul 22, 2021
@eerhardt
Fix build break (#56179)
77d23f0 
Disable the warning until a proper fix can be made.

See #56178
@jozkee jozkee mentioned this issue Jul 22, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 22, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jozkee jozkee

Labels
area-Extensions-FileSystem untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Extensions.FileProviders supported in browser and only unsupport FSW usage jozkee/runtime
2 participants
@eerhardt @jozkee