-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider incrementing the assembly version for source generator with each build #58274
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
See also microsoft/vs-threading#279 |
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsIt appears that the version number of this assembly is locked at 6.0.0.0. This can be problematic for VBCSCompiler during reference package updates, leading to dramatic reduction in compiler throughput (for Roslyn.sln, builds are about 3x slower). The fix for this solution is ensuring the assembly version number increases with each build for analyzer and source generator packages. Originally posted by @sharwell in #58175 (comment)
|
@sharwell we should already have unique assembly versions for publicly shipping GA releases, including servicing. I've made ensuring this part of our servicing readiness plan: #58042. It seems like you're suggesting that even for nightly builds we increment though. Let's consider that. I can see an issue during previews when mixing / matching preview assets. This shouldn't be possible with ref-packs, but could be with the nuget package. For example: if someone has the Preview7 SDK installed, but then has one project where they reference the RC1 (or daily build) NuGet package: those would have the same assembly version but different content. What does https://github.com/dotnet/roslyn-analyzers do? They should have a similar issue (inbox + nuget package). Maybe we can just follow their lead. cc @eerhardt |
It appears that the version number of this assembly is locked at 6.0.0.0. This can be problematic for VBCSCompiler during reference package updates, leading to dramatic reduction in compiler throughput (for Roslyn.sln, builds are about 3x slower). The fix for this solution is ensuring the assembly version number increases with each build for analyzer and source generator packages.
Originally posted by @sharwell in #58175 (comment)
The text was updated successfully, but these errors were encountered: