System.Text.Json.Tests crashing on Mono #58828
Comments
|
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
dotnet-issue-labeler
bot
added
the
untriaged
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsConfiguration:
|
|
@BrzVlad any clue where this should go? I can't see evidence it's JSON (which is all managed code anyway) . But I can't tell which of the threads above is the crash. |
|
Tagging subscribers to this area: @BrzVlad Issue DetailsConfiguration:
|
BrzVlad
removed
area-System.Text.Json
untriaged
|
@BrzVlad hmm... I wonder if I introduced a GC hole here: https://github.com/dotnet/runtime/pull/58215/files#diff-ca87147826c7221d1c277d7a22d042444f21defad5b7a901d771c158243d6e14R3428-R3435 For a runtime-invoke with a large valuetype (>256 bytes) return value, it's allocating the return buffer using malloc instead of writing to the stack. Which means if there's a GC between when the invoke returns and the return valuetype is boxed, the GC won't see any references in it. |
|
@lambdageek could you please take a look ? we hit we had a similar crash, also in JSON. it would be good to avoid having an active GC hole. we have a beautiful dump |
|
@danmoseley The issue is not related to that. There is some GC issue but the stack trace is not enough to figure out what is going on. I tried to reproduce the issue the last time but I failed. I'll try again to reproduce by running this test in a loop for a very long amount of time. |
|
Thanks @BrzVlad .. the dump is not helpful here? |
|
Hitting this again - https://dev.azure.com/dnceng/public/_build/results?buildId=1684019&view=logs&jobId=b4344b0d-0f92-5d69-ccaf-e0b24fbf14a2&j=b4344b0d-0f92-5d69-ccaf-e0b24fbf14a2&t=65a58faa-a542-5344-b5c8-897139f242cd with similar looking trace: |
|
@radical Is there a way to see how often this crash happened in the last months and for which suites ? Crashes containing |
|
https://runfo.azurewebsites.net can be used for this. But I'm not being able to get it to search the helix console logs. |
ghost
added
the
in-pr
ghost
removed
the
in-pr
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Configuration:
net6.0-Linux-Debug-x64-Mono_release-Ubuntu.1604.Amd64.OpenDump available: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-58558-merge-1c1e3bdb886344679d/System.Text.Json.Tests/1/core.1000.13620?sv=2019-07-07&se=2021-09-22T16%3A19%3A20Z&sr=c&sp=rl&sig=sjEJQ%2BswuvmnAmzLahc2AgFLgot5gYVvnZSow7cL6Jg%3D
https://dev.azure.com/dnceng/public/_build/results?buildId=1337984&view=ms.vss-test-web.build-test-results-tab&runId=39211016&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab&resultId=187646
The text was updated successfully, but these errors were encountered: