Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to net7.0 and remove target frameworks #58011

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Upgrade to net7.0 and remove target frameworks #58011

merged 5 commits into from
Sep 8, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Aug 24, 2021 •
edited
Loading

  • Map $(NetCoreAppCurrent) to net7.0 with corresponding 7.0.0.0 assembly versions.
  • Upgrade net461 -> net462 and use an msbuild property to represent the minimum supported .NETFramework version
  • Upgrade netcoreapp3.1 and net5.0 to net6.0 and use an msbuild property to represent the minimum supported .NETCoreApp version
  • Drop netstandard2.1 assets in projects in which both a netstandard2.0 and a .NETCoreApp exists
  • Use TargetFrameworkIdentifier conditions in projects to make tfm changes much easier

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ViktorHofer ViktorHofer changed the title Upgrade to net7.0 and remove EOL targetframeworks Upgrade to net7.0 and remove unsupported target frameworks Aug 24, 2021
@ghost
Copy link

ghost commented Aug 24, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Upgrade net461 -> net462 and use an msbuild property to represent the minimum supported .NETFramework version
  • Upgrade netcoreapp3.1 and net5.0 to net6.0 and use an msbuild property to represent the minimum supported .NETCoreApp version
  • Drop netstandard2.1 assets in projects in which both a netstandard2.0 and a .NETCoreApp exists
  • Use TargetFrameworkIdentifier conditions in projects to make tfm changes much easier
Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure
Milestone: -

This was referenced Aug 24, 2021
Closed
Closed
@ViktorHofer ViktorHofer force-pushed the NET7Upgrade branch 2 times, most recently from 419f247 to b05fd19 Compare August 25, 2021 10:34
@ViktorHofer ViktorHofer changed the title Upgrade to net7.0 and remove unsupported target frameworks Upgrade to net7.0 and remove (unsupported) target frameworks Aug 25, 2021
@ViktorHofer ViktorHofer mentioned this pull request Aug 26, 2021
Closed
@ViktorHofer ViktorHofer marked this pull request as ready for review August 26, 2021 19:01
@ViktorHofer ViktorHofer self-assigned this Aug 26, 2021
@ViktorHofer ViktorHofer changed the title Upgrade to net7.0 and remove (unsupported) target frameworks Upgrade to net7.0 and remove target frameworks Aug 26, 2021
@ViktorHofer
Copy link
Member Author

The PR is now ready. @eerhardt and @Anipik I would appreciate a review. I understand that this is challenging based on the amount of changes but most are trivial search and replace ones.

@ViktorHofer ViktorHofer removed the request for review from marek-safar September 8, 2021 07:37
@ViktorHofer
Copy link
Member Author

runtime-staging timeout is #58549

@ViktorHofer ViktorHofer closed this Sep 8, 2021
@ViktorHofer ViktorHofer reopened this Sep 8, 2021
@ViktorHofer
Copy link
Member Author

Failure is #58828
Hang is #58549

@ViktorHofer ViktorHofer merged commit 67354a2 into main Sep 8, 2021
@ViktorHofer ViktorHofer deleted the NET7Upgrade branch September 8, 2021 20:04
@eerhardt eerhardt mentioned this pull request Sep 14, 2021
Merged
@kunalspathak kunalspathak mentioned this pull request Sep 15, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2021
@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Sep 15, 2022
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Sep 15, 2022
@ericstj ericstj added this to the 7.0.0 milestone Sep 15, 2022
@ViktorHofer
Copy link
Member Author

Breaking change issue filed: dotnet/docs#31399.

@ViktorHofer ViktorHofer removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt left review comments

@ericstj ericstj ericstj left review comments

@Anipik Anipik Anipik approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktorHofer @eerhardt @ericstj @Anipik