Test failure System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo) #60240

VincentBu · 2021-10-11T01:56:22Z

Run: runtime-coreclr libraries-jitstressregs 20211010.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

category:correctness
theme:testing
skill-level:intermediate
cost:medium
impact:small

The text was updated successfully, but these errors were encountered:

ghost · 2021-10-11T01:56:26Z

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr libraries-jitstressregs 20211010.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

Author:	VincentBu
Assignees:	-
Labels:	`arch-x86`, `area-System.Console`, `os-windows`, `untriaged`
Milestone:	-

carlossanlop · 2021-10-13T17:26:30Z

@dotnet/jit-contrib can anyone here help us investigate this issue?

The ConsoleKeyInfo has not been change for months.

This JIT test leg seems to be running once a week. This console test passes 47 times, and fails once, on Windows 10 amd64, with CoreCLR x86. https://dev.azure.com/dnceng/public/_test/analytics?definitionId=668&contextType=build

The test is comparing ConsoleKeyInfo instances. The .Equals() methods pass, but the == comparison fails.

Test log: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-5a8e57a8f2b14ffe9b/System.Console.Tests/1/console.dd29db9d.log?sv=2019-07-07&se=2021-10-30T09%3A32%3A44Z&sr=c&sp=rl&sig=CwCNOuPBFlwnNhP8FR4dwL0nJ7DVi5MHgRJFaJnOJTs%3D

Here's the code that fails:

runtime/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs

Lines 40 to 42 in 57bfe47

    
           Assert.True(cki.Equals((object)other)); 
        
           Assert.True(cki.Equals(other)); 
        
           Assert.True(cki == other);

ConsoleKeyInfo is a readonly struct:

runtime/src/libraries/System.Console/src/System/ConsoleKeyInfo.cs

Line 8 in 57bfe47

public readonly struct ConsoleKeyInfo : IEquatable<ConsoleKeyInfo>

ghost · 2021-10-13T17:26:48Z

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr libraries-jitstressregs 20211010.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

Author:	VincentBu
Assignees:	-
Labels:	`arch-x86`, `area-System.Console`, `os-windows`, `area-CodeGen-coreclr`
Milestone:	-

JulieLeeMSFT · 2021-10-13T22:18:45Z

@EgorBo PTAL.
cc @dotnet/jit-contrib

VincentBu · 2021-10-25T02:45:14Z

Failed again in: runtime-coreclr libraries-jitstressregs 20211024.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

VincentBu · 2021-11-08T01:36:33Z

Failed again in: runtime-coreclr libraries-jitstressregs 20211107.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

VincentBu · 2021-11-22T02:50:36Z

Failed again in: runtime-coreclr libraries-jitstressregs 20211121.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

VincentBu · 2021-12-06T01:49:21Z

Failed again in: runtime-coreclr libraries-jitstressregs 20211205.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

VincentBu · 2021-12-20T01:34:20Z

Failed again in: runtime-coreclr libraries-jitstressregs 20211219.1

Failed test:


net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

VincentBu · 2022-01-04T01:59:16Z

Failed again in: runtime-coreclr libraries-jitstressregs 20220102.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

EgorBo · 2022-08-12T15:22:02Z

I wasn't able to reproduce this, but I'll try again on Monday once I am home and backport to 7.0 if it turns out to be important/gc hole

EgorBo · 2023-08-09T21:15:15Z

Doesn't repro no matter what, I'll file a PR to re-enable this test

VincentBu added arch-x86 os-windows labels Oct 11, 2021

dotnet-issue-labeler bot added area-System.Console untriaged New issue has not been triaged by the area owner labels Oct 11, 2021

carlossanlop added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed untriaged New issue has not been triaged by the area owner labels Oct 13, 2021

carlossanlop added JitStress CLR JIT issues involving JIT internal stress modes untriaged New issue has not been triaged by the area owner and removed area-System.Console labels Oct 13, 2021

JulieLeeMSFT assigned EgorBo Oct 13, 2021

JulieLeeMSFT added needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration and removed untriaged New issue has not been triaged by the area owner labels Oct 13, 2021

JulieLeeMSFT modified the milestones: 6.0.0, 7.0.0 Oct 13, 2021

This was referenced Jan 4, 2022

Logging in console test to help understand #60240 #63326

Merged

Disable console test for jitstressreg mode #63349

Merged

jkotas added disabled-test The test is disabled in source code against the issue bug labels Jan 5, 2022

EgorBo modified the milestones: 7.0.0, 8.0.0 Aug 12, 2022

EgorBo modified the milestones: 8.0.0, 9.0.0 Aug 9, 2023

EgorBo added the Priority:2 Work that is important, but not critical for the release label Jul 22, 2024

stephentoub mentioned this issue Jul 23, 2024

Re-enable ConsoleKeyInfoTests.Equals_SameData test #105355

Merged

dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jul 23, 2024

stephentoub closed this as completed in #105355 Jul 24, 2024

github-actions bot locked and limited conversation to collaborators Aug 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test failure System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo) #60240

Test failure System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo) #60240

VincentBu commented Oct 11, 2021 •

edited by BruceForstall

Loading

ghost commented Oct 11, 2021

carlossanlop commented Oct 13, 2021

ghost commented Oct 13, 2021

JulieLeeMSFT commented Oct 13, 2021

VincentBu commented Oct 25, 2021

VincentBu commented Nov 8, 2021

VincentBu commented Nov 22, 2021

VincentBu commented Dec 6, 2021

VincentBu commented Dec 20, 2021

VincentBu commented Jan 4, 2022

EgorBo commented Aug 12, 2022

EgorBo commented Aug 9, 2023

Test failure System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo) #60240

Test failure System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo) #60240

Comments

VincentBu commented Oct 11, 2021 • edited by BruceForstall Loading

ghost commented Oct 11, 2021

carlossanlop commented Oct 13, 2021

ghost commented Oct 13, 2021

JulieLeeMSFT commented Oct 13, 2021

VincentBu commented Oct 25, 2021

VincentBu commented Nov 8, 2021

VincentBu commented Nov 22, 2021

VincentBu commented Dec 6, 2021

VincentBu commented Dec 20, 2021

VincentBu commented Jan 4, 2022

EgorBo commented Aug 12, 2022

EgorBo commented Aug 9, 2023

VincentBu commented Oct 11, 2021 •

edited by BruceForstall

Loading