Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging in console test to help understand #60240 #63326

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

danmoseley
Copy link
Member

Relates to #60240

Hopefully this won't break the repro.

@ghost
Copy link

ghost commented Jan 4, 2022

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

Relates to #60240

Hopefully this won't break the repro.

Author: danmoseley
Assignees: danmoseley
Labels:

area-System.Console

Milestone: -

@danmoseley danmoseley merged commit 312c66f into dotnet:main Jan 4, 2022
@danmoseley danmoseley deleted the console.test branch January 4, 2022 06:38
@jkotas
Copy link
Member

jkotas commented Jan 4, 2022

Hopefully this won't break the repro.

This change breaks the repro.

It repros 100% of the time before this change for me. It never repros for me after this change.

Repro steps:

build.cmd -c Release -rc checked -arch x86 -s clr+libs+libs.pretest+libs.tests
cd src\libraries\System.Console\tests
set COMPlus_TieredCompilation=0
set COMPlus_JitStressRegs=1
dotnet build /t:Test /p:TargetArchitecture=x86 -c Release

This is JIT register allocator stress bug. FWIW, I do not think that logging like this will help with investigation. The JIT folks will need the disassembly and the JIT log to figure out the problem.

@danmoseley
Copy link
Member Author

Ah interesting. Meantime, we presumably don't want to leave tests failing. I can revert the logging, if there's a better way to stop the failure.

@jkotas
Copy link
Member

jkotas commented Jan 4, 2022

Disable the test against the issue using RuntimeTestModes.JitStressRegs (https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.XUnitExtensions/src/RuntimeTestModes.cs#L21).

danmoseley added a commit to danmoseley/runtime that referenced this pull request Jan 4, 2022
danmoseley added a commit that referenced this pull request Jan 4, 2022
* Revert "logging (#63326)"

This reverts commit 312c66f.

* disable test for jit stress regs
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants