Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail superpmi replay job if the only problem is MISSING data #61616

Closed
BruceForstall opened this issue Nov 15, 2021 · 2 comments · Fixed by #61699
Closed

Don't fail superpmi replay job if the only problem is MISSING data #61616

BruceForstall opened this issue Nov 15, 2021 · 2 comments · Fixed by #61699
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
7.0.0

Comments

@BruceForstall
Copy link
Member

It appears that the superpmi replay job (1, 2) fails if the only problem is SuperPMI MISSING data due to drift between JIT and SPMI collections and the JIT/EE interface calls made.

We shouldn't fail the job (or report an error) if that occurs; it should be ignored.
@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 15, 2021
@BruceForstall BruceForstall added this to the 7.0.0 milestone Nov 15, 2021
@ghost
Copy link

ghost commented Nov 15, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

It appears that the superpmi replay job (1, 2) fails if the only problem is SuperPMI MISSING data due to drift between JIT and SPMI collections and the JIT/EE interface calls made.

We shouldn't fail the job (or report an error) if that occurs; it should be ignored.

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: 7.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 15, 2021
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Nov 15, 2021
@BruceForstall
Copy link
Member Author

The same issue applies to the asmdiffs job, as described here: #61483

@kunalspathak kunalspathak mentioned this issue Nov 16, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 16, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Ignore missing data result from superpmi-replay run kunalspathak/runtime
1 participant
@BruceForstall