Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing data result from superpmi-replay run #61699

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

kunalspathak
Copy link
Member

If the errors are "missing data" related, ignore them and don't treat it as run failure. With this, superpmi.log will not list the method context ids under Method numbers with compilation failures: section.

Fixes: #61616 and contributes to #61483

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 16, 2021
@ghost
Copy link

ghost commented Nov 16, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

If the errors are "missing data" related, ignore them and don't treat it as run failure. With this, superpmi.log will not list the method context ids under Method numbers with compilation failures: section.

Fixes: #61616 and contributes to #61483

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib , @BruceForstall

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't fail superpmi replay job if the only problem is MISSING data
2 participants