Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] JS Interop tests failing with latest chrome - JavaScript host object 'SharedArrayBuffer' not found #61945

Closed
radical opened this issue Nov 22, 2021 · 7 comments · Fixed by #62016
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript disabled-test The test is disabled in source code against the issue

Comments

@radical
Copy link
Member

radical commented Nov 22, 2021

#61937 upgrades chrome used to run the tests, to the latest stable version - 96.0.4664.45:

[22:46:06] fail: [FAIL] System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTests.CoreTypes
[22:46:06] info: System.Runtime.InteropServices.JavaScript.JSException : JavaScript host object 'SharedArrayBuffer' not found.
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.Runtime.CreateCSOwnedObject(JSObject proxy, String typeName, Object[] parms)
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.JSObject..ctor(String typeName, Object[] _params)
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.CoreObject..ctor(String typeName, Object[] _params)
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.SharedArrayBuffer..ctor(Int32 length)
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTests.CoreTypes()
[22:46:06] info:    at System.Reflection.RuntimeMethodInfo.InvokeWorker(Object obj, BindingFlags invokeAttr, Span`1 parameters)

Build, and Log

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 22, 2021
@ghost
Copy link

ghost commented Nov 22, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

#61937 upgrades chrome used to run the tests, to the latest stable version - 96.0.4664.45:

[22:46:06] fail: [FAIL] System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTests.CoreTypes
[22:46:06] info: System.Runtime.InteropServices.JavaScript.JSException : JavaScript host object 'SharedArrayBuffer' not found.
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.Runtime.CreateCSOwnedObject(JSObject proxy, String typeName, Object[] parms)
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.JSObject..ctor(String typeName, Object[] _params)
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.CoreObject..ctor(String typeName, Object[] _params)
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.SharedArrayBuffer..ctor(Int32 length)
[22:46:06] info:    at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTests.CoreTypes()
[22:46:06] info:    at System.Reflection.RuntimeMethodInfo.InvokeWorker(Object obj, BindingFlags invokeAttr, Span`1 parameters)

Build, and Log

Author: radical
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: -

@radical
Copy link
Member Author

radical commented Nov 22, 2021

cc @kg @pavelsavara

@radical
Copy link
Member Author

radical commented Nov 22, 2021

@kg
Copy link
Contributor

kg commented Nov 22, 2021

What version of chrome was it previously? They're changing the requirements to access it. https://developer.chrome.com/blog/enabling-shared-array-buffer/

@radical
Copy link
Member Author

radical commented Nov 22, 2021

We were running with - 84.0.4147.105

radical added a commit to radical/runtime that referenced this issue Nov 22, 2021
@radical radical added the disabled-test The test is disabled in source code against the issue label Nov 23, 2021
@kg
Copy link
Contributor

kg commented Nov 23, 2021

Then based on that post I linked, this is an expected failure and we need to make policy header changes. I don't know exactly how it works since COEP/COOP/etc headers are a nightmare. It might be as simple as generating the right headers in whatever httpd we use to serve tests.

@pavelsavara
Copy link
Member

I can reproduce it locally. I will have look at xharness http server and see if we could set the headers.
Possibly there are few remaining endpoints we touch on Azure for HTTP unit tests in [OuterLoop] I wonder if that's impacted.

@pavelsavara pavelsavara removed the untriaged New issue has not been triaged by the area owner label Nov 23, 2021
radical added a commit that referenced this issue Nov 24, 2021
- Update chrome+chromedriver for helix tests to latest stable (`96.0.4664.45`)
- Enable library tests to run on Windows, for manual runs

- Disable windows/AOT builds completely due to #61721
- Disable failing WBT tests on windows due to #61725
- Disable JS interop tests failing with new chrome - #61945

Co-authored-by: Radek Doulik <radek.doulik@gmail.com>
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 24, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 29, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants