Test failure System.IO.FileSystem.Tests.DriveInfoWindowsTests.TestGetDrives

[VincentBu]

Run: runtime-coreclr libraries-jitstress 20211127.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstress1_tiered-Windows.10.Amd64.Open

- System.IO.FileSystem.Tests.DriveInfoWindowsTests.TestGetDrives

Error message:

Assert.Contains() Failure
Not found: 'F'
In value:  <GetValidDriveLettersOnMachine>d__15 ['C', 'D', 'E']


Stack trace
   at System.IO.FileSystem.Tests.DriveInfoWindowsTests.TestGetDrives() in /_/src/libraries/System.IO.FileSystem.DriveInfo/tests/DriveInfo.Windows.Tests.cs:line 66

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run: runtime-coreclr libraries-jitstress 20211127.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstress1_tiered-Windows.10.Amd64.Open

- System.IO.FileSystem.Tests.DriveInfoWindowsTests.TestGetDrives

Error message:

Assert.Contains() Failure
Not found: 'F'
In value:  <GetValidDriveLettersOnMachine>d__15 ['C', 'D', 'E']


Stack trace
   at System.IO.FileSystem.Tests.DriveInfoWindowsTests.TestGetDrives() in /_/src/libraries/System.IO.FileSystem.DriveInfo/tests/DriveInfo.Windows.Tests.cs:line 66

Author:	VincentBu
Assignees:	-
Labels:	arch-x86, area-System.IO, os-windows, JitStress
Milestone:	-

[danmoseley]

This test is essentially verifying that this code
https://github.com/danmoseley/runtime/blob/8e143ac4f87a2055b21f7f479a3fd7ce695bc580/src/libraries/System.IO.FileSystem.DriveInfo/tests/DriveInfo.Windows.Tests.cs#L269
does the same thing as this code
https://github.com/danmoseley/runtime/blob/8e143ac4f87a2055b21f7f479a3fd7ce695bc580/src/libraries/System.Private.CoreLib/src/System/IO/DriveInfoInternal.Windows.cs#L11

Eyeballing it, it does. So my guesses are either

1. A drive was concurrently removed/unmapped, possibly by another test running concurrently.
2. Windows is returning flaky results
3. JIT stress is doing something.

I'm guessing 1.

[danmoseley]

Looks like this was (re)introduced by #59850

@carlossanlop what is preventing SetVolumeLabel_OnVirtualDrive_Throws and the tests in DriveInfoWindowsTests from running concurrently? if only DriveInfoWindowsTests would be affected, we can simply move this test into that class.

[adamsitnik]

what is preventing SetVolumeLabel_OnVirtualDrive_Throws and the tests in DriveInfoWindowsTests from running concurrently

It's more or less:

test1: gets list of drives
test2: add/remove temp drive
test1: gets list of drives and compares it against list from step 1

I've sent #62134 to disable the parallelization for this test project.

[danmoseley]

Right it was a rhetorical question 🙂