-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DllImportGenerator is failing in Mono llvmfullAOT #62372
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
@jkoritzinsky Looks like this was somehow caused by 84b55d9 |
We're probably constructing Core_Root in some way that either overrides OutputPath or OutputItemType for ProjectReferences |
@jkoritzinsky we should exclude DllImportGenerator from Core_Root. For the various Mono AOT testing legs, I think we AOT every assembly in Core_Root. The Mono AOT process needs to be able to resolve every assembly reference (using the Core_Root and the individual test - the search path is constructed in src/mono/msbuild/aot-compile.proj although I don't know the details of how this gets used by the runtime tests build script). In this case DllImportGenerator is in Core_Root but the various Roslyn assemblies aren't. I think the cleanest approach would be to ensure that the DllImportGenerator assembly doesn't end up in Core_Root - after all it's needed only at build-time not run-time. (And I assume Core_Root is not used to build the tests) |
@lambdageek I agree with your assessment. These two assemblies should be excluded from Core_Root. |
These appear to be failing because Microsoft.CodeAnalysis isn't present, but that's expected behavior for source generators/analyzers, as they are plugins. Fixes #62372
The libraries build infra normally does this automatically but the interop source generator doesn't follow the path convention. Without this manifestation, the build considers the generator part of framework and it gets binplaced into places where it shouldn't be. Fixes dotnet#62372.
https://dev.azure.com/dnceng/public/_build/results?buildId=1496054
The text was updated successfully, but these errors were encountered: