-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect assert for cgroup file system type #62960
Comments
dotnet-issue-labeler
bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Dec 17, 2021
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
This isn't mono-specific, moving to |
janvorli
added a commit
to janvorli/runtime
that referenced
this issue
Jul 18, 2022
When detecting the current cgroup version on Linux, checked and debug builds assert when the filesystem type of /sys/fs/cgroup is neither TMPFS_MAGIC nor CGROUP2_SUPER_MAGIC. This change removes the assert and considers it as "no cgroup support". Release builds already have this behavior. Close dotnet#62960
ghost
added
the
in-pr
There is an active PR which will close this issue when it is merged
label
Jul 18, 2022
janvorli
added a commit
that referenced
this issue
Jul 22, 2022
* Remove wrong cgroups assert When detecting the current cgroup version on Linux, checked and debug builds assert when the filesystem type of /sys/fs/cgroup is neither TMPFS_MAGIC nor CGROUP2_SUPER_MAGIC. This change removes the assert and considers it as "no cgroup support". Release builds already have this behavior. Close #62960 * Update the nativeaot version too
ghost
removed
the
in-pr
There is an active PR which will close this issue when it is merged
label
Jul 22, 2022
ghost
locked as resolved and limited conversation to collaborators
Aug 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From mono/mono#21280 (comment):
We should fix this assert (which just happens to become a no-op at Release builds) to correctly handle environments in which cgroups are not enabled, specially chroots.
cc @akoeplinger @janvorli @tmds
The text was updated successfully, but these errors were encountered: