Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up for Assembly.GetCallingAssembly() - tests and stack walk #69251

Closed
steveharter opened this issue May 12, 2022 · 2 comments · Fixed by #69575
Closed

Follow-up for Assembly.GetCallingAssembly() - tests and stack walk #69251

steveharter opened this issue May 12, 2022 · 2 comments · Fixed by #69575
Assignees
@steveharter
Labels
area-System.Reflection
Milestone
7.0.0

Comments

@steveharter
Copy link
Member

Address todos in #69225:

  • Add tests.
  • Determine a better way to detect the dynamic methods to avoid any potential naming collision.
@steveharter steveharter added this to the 7.0.0 milestone May 12, 2022
@steveharter steveharter self-assigned this May 12, 2022
@ghost
Copy link

ghost commented May 12, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Address todos in #69225:

  • Add tests.
  • Determine a better way to detect the dynamic methods to avoid any potential naming collision.
Author: steveharter
Assignees: steveharter
Labels:

area-System.Reflection
Milestone: 7.0.0

@steveharter steveharter mentioned this issue May 12, 2022
Merged
@steveharter
Copy link
Member Author

Also we have #68923 to track hiding reflection frames; the research into that issue may overlap with this one.

@kasperk81 kasperk81 mentioned this issue May 15, 2022
Merged
@steveharter steveharter mentioned this issue May 23, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 23, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@steveharter steveharter

Labels
area-System.Reflection
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Add IL Emit support for MethodInfo.Invoke() and friends steveharter/runtime
1 participant
@steveharter