-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblock SDK merge by fixing Assembly.GetCallingAssembly() #69225
Conversation
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsSDK merge is blocked due to test failures; see dotnet/sdk#25317 (comment). The issue is that the test is calling Todo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the TODOs
@steveharter Do we want an issue to track this or is this next on your plate? |
Test failures due to #69232 |
Added #69251 |
This reverts commit 8420dae.
SDK merge is blocked due to test failures; see dotnet/sdk#25317 (comment).
The issue is that the test is calling
Assembly.GetCallingAssembly()
which returns the "Anonymously Hosted DynamicMethods Assembly" instead of the expected assembly. This broke due to the recent Invoke+Emit work where aDynamicMethod
is created to invoke that method and the native code that attempts to skip the reflection stack frames was not correct.Todo:
GetCallingAssembly()
. However, adding the equivalent to an Xunit test I was unable to reproduce the issue. The console app included several more stack frames, including the "InvokeStub_" frame and theMethodInvoker
orConstructorInvoker
frame however the xUnit test did not include those frames. We need to determine why this is the case and add an appropriate test.