-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ProfilerAPI] No more ModuleLoadFinished callbacks for dynamic modules #76016
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @tommcdon Issue DetailsHi there, .NET 7.0 rc1 doesn't send Example: using System;
using System.Reflection;
using System.Reflection.Emit;
namespace DynamicAssemblyTestProgram
{
internal static class DynamicAssemblyTestProgram
{
internal static void Main()
{
var type = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("TestAssembly"), AssemblyBuilderAccess.Run)
.DefineDynamicModule("TestModule")
.DefineType("TestClass", TypeAttributes.Public)
.CreateType();
var obj = Activator.CreateInstance(type);
if (obj == null)
throw new NullReferenceException();
Console.WriteLine("Done!");
Console.ReadKey();
GC.KeepAlive(obj);
}
}
} Profiler log, see
|
Hi, there, |
I opened #77068 to fix this issue, once it is checked in I will open a servicing request for 7.0. |
@alanwest @kolesnikovae not sure if you are subscribed to the profiler interest group, but wanted to make sure you saw #9305 (comment) since we have chatted about ICorProfiler and it may impact you |
Can it be sooner than January? It is not even November and I think runtime bugs should not be treated lightly 😉 |
Thank you for letting me know @davmason, I joined the group. Indeed, we noticed some symptoms of the problem while testing compatibility of our integration (uses EventPipe) with .NET 7 Preview. I think I should have reported this issue, but I was sure the problem is somewhere on our side. |
Unfortunately January is our first servicing release, we do not ship any updates in December. |
Hi there,
.NET 7.0 rc1 doesn't send
ICorProfilerCallback::ModuleLoadFinished
for dynamic modules any more. .NET 6.0.9 works properly.Example:
Profiler log, see
00007FFC14200110
:The text was updated successfully, but these errors were encountered: