-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm debugger test timing out #83847
Comments
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=214012 Error MessageFill the error message using known issues guidance. {
"ErrorMessage": "",
"BuildRetry": false,
"ErrorPattern": "Test timed out(.|\n|\r)*wasm",
"ExcludeConsoleLog": true
}
|
@jkoritzinsky @hoyosjs Could you check the regex I used here and see if it matches like I think it does? I'm not sure if multi-line works or whether it works like I think. |
Yeah, I don't think this worked. @markwilkie any chance you could provide insight to what I'm doing wrong? |
I am looking at it, but I am not sure what you are trying to match it against. |
Ah, I'm trying to match this console log: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-83787-merge-8c3242e441a340b79e/chrome-DebuggerTests.SteppingTests/1/console.cbbe6fd0.log?helixlogtype=result In particular, the test output "Test timed out", then having it walk all the way down to the stack trace, where the string "wasm" appears. Basically, I want to catch timeouts where wasm is involved. |
This would match:
I am unsure if these regex searches work with multiple lines. Is there a reason why you don't want to regex-match the error lines that look like this?:
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=214012 Error MessageFill the error message using known issues guidance. {
"ErrorMessage": "",
"BuildRetry": false,
"ErrorPattern": "Test timed out(.|\n|\r)*wasm",
"ExcludeConsoleLog": true
} ReportSummary
|
I assumed the test could fail for more reasons than this and we would still want to catch it, but tbh that's probably better to start with. |
@agocke confirmed, the search is not multiline: https://github.com/dotnet/arcade/blob/main/Documentation/Projects/Build%20Analysis/KnownIssues.md#regex-matching Can only match one line, no backtracking, and is case insensitive. I think if we have many different types of timeouts, it's ok to have multiple issues open if we are able to match unique lines from the error output. Even if they have the same root cause in the end, at least we can get them marked as Known Build Error. |
@agocke you set |
Oops. Fixed :) |
Hmm, it's definitely sad if multiline is not allowed though... And that new test string seems a bit too wide. That sounds like a red herring for a debugger hang. |
I am not surprised if that's always the case even if it's a good run. |
@thaystg committed a fix and it seems to be working |
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=214012
Build error leg or test failing: chrome-DebuggerTests.SteppingTests.WorkItemExecution
Pull request: #83787
Error Message
Fill the error message using known issues guidance.
Report
Summary
The text was updated successfully, but these errors were encountered: