Prepare ComInterfaceGenerator for going into the public API #83894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkoritzinsky
commented
Mar 24, 2023
jkoritzinsky
commented
- Rename the exception marshallers per API review.
- Since we aren't going to expose the "object unwrapper" mechanism until we expose the generic "vtable" logic, change the ComInterfaceGenerator to use the ComWrappers.ComInterfaceDispatch APIs directly.
- Separate more of the code between the VirtualMethodIndex generator and the ComInterface generator so we don't have the unsupported generator code influencing the shipping generator's code.
- Rename the exception marshallers per API review. - Since we aren't going to expose the "object unwrapper" mechanism until we expose the generic "vtable" logic, change the ComInterfaceGenerator to use the ComWrappers.ComInterfaceDispatch APIs directly. - Separate more of the code between the VirtualMethodIndex generator and the ComInterface generator so we don't have the unsupported generator code influencing the shipping generator's code.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
jtschuster and
elinor-fung
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue Details
|
This was referenced Mar 24, 2023
...teropServices/gen/ComInterfaceGenerator/Marshallers/ComInterfaceDispatchMarshallerFactory.cs
Show resolved
Hide resolved
...teropServices/gen/ComInterfaceGenerator/Marshallers/ComInterfaceDispatchMarshallerFactory.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.