Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override IsByRefLike property getter on RefEmit.***Builder classes. #8828

Closed
ghost opened this issue Aug 29, 2017 · 1 comment · Fixed by #34846
Closed

Override IsByRefLike property getter on RefEmit.***Builder classes. #8828

ghost opened this issue Aug 29, 2017 · 1 comment · Fixed by #34846
Labels
area-System.Reflection.Emit good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Milestone
5.0.0

Comments

@ghost
Copy link

ghost commented Aug 29, 2017

They can just return false - this is for consistency with how other RefEmit Type-derived classes handle the Is predicates.
@ghost ghost self-assigned this Aug 29, 2017
@ghost ghost removed their assignment Sep 12, 2018
@FizzBuzz791
Copy link

@atsushikan any pointers on this?

Is this issue actually meant to be for the dotnet/corefx repo? Seems like it might be, based on the PR above.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@steveharter steveharter modified the milestones: Future, 5.0 Feb 11, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 26, 2020
@GrabYourPitchforks GrabYourPitchforks removed the untriaged New issue has not been triaged by the area owner label Mar 10, 2020
@GrabYourPitchforks GrabYourPitchforks changed the title Override IsByRefLikeImpl() on RefEmit.***Builder classes. Override IsByRefLike() on RefEmit.***Builder classes. Mar 10, 2020
@GrabYourPitchforks GrabYourPitchforks changed the title Override IsByRefLike() on RefEmit.***Builder classes. Override IsByRefLike property getter on RefEmit.***Builder classes. Mar 10, 2020
marcusturewicz added a commit to marcusturewicz/runtime that referenced this issue Apr 11, 2020
@marcusturewicz
Override IsByRefLike on S.R.E.*Builder classes
87e4fd2 
Fixes dotnet#8828
@marcusturewicz marcusturewicz mentioned this issue Apr 11, 2020
Merged
stephentoub pushed a commit that referenced this issue Apr 20, 2020
@marcusturewicz
Override IsByRefLike on S.R.E.*Builder classes (#34846)
cfb1335 
* Override IsByRefLike on S.R.E.*Builder classes

Fixes #8828

* Adds tests

* Update System.Reflection.Emit.Tests.csproj

* Bumping CI

* Update mono as well
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Reflection.Emit good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Override IsByRefLike on S.R.E.*Builder classes marcusturewicz/runtime
6 participants
@ghost @GrabYourPitchforks @FizzBuzz791 @maryamariyan @steveharter @msftgits