Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Lot of HybridGlobalization test failures with NodeJS #95983

Closed
radical opened this issue Dec 13, 2023 · 2 comments · Fixed by #96003
Closed

[wasm] Lot of HybridGlobalization test failures with NodeJS #95983

radical opened this issue Dec 13, 2023 · 2 comments · Fixed by #96003
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Globalization blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'

Comments

@radical
Copy link
Member

radical commented Dec 13, 2023

Build Information

Build:https://dev.azure.com/dnceng-public/public/_build/results?buildId=498273
Build error leg or test failing: WasmTestOnNodeJS-System.Globalization.Hybrid.WASM.Tests
Pull request: #95959

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Failing tests can be seen in the generated wasm-console.log, like:

[FAIL] System.Globalization.Tests.DateTimeFormatInfoAbbreviatedMonthNames.AbbreviatedMonthNames_Get_ReturnsExpected_HybridGlobalization(cultureName: "nl-NL", expected: ["jan.", "feb.", "mrt.", "apr.", "mei", ···])
Failed for culture: nl-NL on index: 0. Expected: jan., Actual: jan
   at System.Globalization.Tests.DateTimeFormatInfoAbbreviatedMonthNames.AbbreviatedMonthNames_Get_ReturnsExpected_HybridGlobalization(String cultureName, String[] expected)
   at System.Object.InvokeStub_DateTimeFormatInfoAbbreviatedMonthNames.AbbreviatedMonthNames_Get_ReturnsExpected_HybridGlobalization(Object , Span`1 )
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

[FAIL] System.Globalization.Tests.DateTimeFormatInfoShortDatePattern.ShortDatePattern_Get_ReturnsExpected_HybridGlobalization(cultureName: "en-CH", expected: "dd/MM/yyyy")
Failed for culture: en-CH. Expected: dd/MM/yyyy, Actual: dd.MM.yyyy
   at System.Globalization.Tests.DateTimeFormatInfoShortDatePattern.ShortDatePattern_Get_ReturnsExpected_HybridGlobalization(String cultureName, String expected)
   at System.Object.InvokeStub_DateTimeFormatInfoShortDatePattern.ShortDatePattern_Get_ReturnsExpected_HybridGlobalization(Object , Span`1 )
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

[FAIL] System.Globalization.Tests.DateTimeFormatInfoNativeCalendarName.NativeCalendarName_Get_ReturnsExpected_HybridGlobalization(format: DateTimeFormatInfo { AbbreviatedDayNames = ["እሑድ", "ሰኞ", "ማክሰ", "ረቡዕ", "ሐሙስ", ···], AbbreviatedMonthGenitiveNames = >
Assert.Equal() Failure: Strings differ
           ↓ (pos 0)
Expected: "GREGORIAN"
Actual:   "gregory"
           ↑ (pos 0)
   at System.Object.InvokeStub_DateTimeFormatInfoNativeCalendarName.NativeCalendarName_Get_ReturnsExpected_HybridGlobalization(Object , Span`1 )
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

222 failures.

And similar failures are seen for System.Globalization.Tests.

cc @ilonatommy

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@radical radical added arch-wasm WebAssembly architecture area-System.Globalization blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Dec 13, 2023
@ghost
Copy link

ghost commented Dec 13, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build:https://dev.azure.com/dnceng-public/public/_build/results?buildId=498273
Build error leg or test failing: WasmTestOnNodeJS-System.Globalization.Hybrid.WASM.Tests
Pull request: #95959

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Failing tests can be seen in the generated wasm-console.log, like:

[FAIL] System.Globalization.Tests.DateTimeFormatInfoAbbreviatedMonthNames.AbbreviatedMonthNames_Get_ReturnsExpected_HybridGlobalization(cultureName: "nl-NL", expected: ["jan.", "feb.", "mrt.", "apr.", "mei", ···])
Failed for culture: nl-NL on index: 0. Expected: jan., Actual: jan
   at System.Globalization.Tests.DateTimeFormatInfoAbbreviatedMonthNames.AbbreviatedMonthNames_Get_ReturnsExpected_HybridGlobalization(String cultureName, String[] expected)
   at System.Object.InvokeStub_DateTimeFormatInfoAbbreviatedMonthNames.AbbreviatedMonthNames_Get_ReturnsExpected_HybridGlobalization(Object , Span`1 )
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

[FAIL] System.Globalization.Tests.DateTimeFormatInfoShortDatePattern.ShortDatePattern_Get_ReturnsExpected_HybridGlobalization(cultureName: "en-CH", expected: "dd/MM/yyyy")
Failed for culture: en-CH. Expected: dd/MM/yyyy, Actual: dd.MM.yyyy
   at System.Globalization.Tests.DateTimeFormatInfoShortDatePattern.ShortDatePattern_Get_ReturnsExpected_HybridGlobalization(String cultureName, String expected)
   at System.Object.InvokeStub_DateTimeFormatInfoShortDatePattern.ShortDatePattern_Get_ReturnsExpected_HybridGlobalization(Object , Span`1 )
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

[FAIL] System.Globalization.Tests.DateTimeFormatInfoNativeCalendarName.NativeCalendarName_Get_ReturnsExpected_HybridGlobalization(format: DateTimeFormatInfo { AbbreviatedDayNames = ["እሑድ", "ሰኞ", "ማክሰ", "ረቡዕ", "ሐሙስ", ···], AbbreviatedMonthGenitiveNames = >
Assert.Equal() Failure: Strings differ
           ↓ (pos 0)
Expected: "GREGORIAN"
Actual:   "gregory"
           ↑ (pos 0)
   at System.Object.InvokeStub_DateTimeFormatInfoNativeCalendarName.NativeCalendarName_Get_ReturnsExpected_HybridGlobalization(Object , Span`1 )
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

222 failures.

And similar failures are seen for System.Globalization.Tests.

cc @ilonatommy

Author: radical
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization, blocking-clean-ci

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 13, 2023
@ilonatommy
Copy link
Member

On the PR that was switching on the HG job, I did not manage to have the NodeJS version updated and I adjusted the tests on Windows to the old version. Now it seems the changes got propagated just fine. It's an easy fix

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 14, 2023
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Dec 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Globalization blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants