Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntermediateAssembly should be used in ILC inputs #99731

Closed
MrJul opened this issue Mar 13, 2024 · 0 comments · Fixed by #99732
Closed

IntermediateAssembly should be used in ILC inputs #99731

MrJul opened this issue Mar 13, 2024 · 0 comments · Fixed by #99732
Labels
area-NativeAOT-coreclr
Milestone
9.0.0

Comments

@MrJul
Copy link
Contributor

MrJul commented Mar 13, 2024

Currently, NativeAOT hardcodes its main input to be $(IntermediateOutputPath)$(TargetName)$(TargetExt) through the ComputeIlcCompileInputs target:

runtime/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

Line 171 in eb864bf

<ManagedBinary Condition="$(BuildingFrameworkLibrary) != 'true'" Include="$(IntermediateOutputPath)$(TargetName)$(TargetExt)" />

It would be nice to have this target use the @(IntermediateAssembly) item instead.

The current behavior can be problematic when you happen to have any custom target adjusting that item. This requires the target to also be aware of ILC targets, as seen here: AvaloniaUI/Avalonia#14966

As far as I can tell, build, standard publish and ILLink all seem to respect changing @(IntermediateAssembly), only ILC doesn't.

Is there any reason for the current behavior? Is it possible to use @(IntermediateAssembly) for consistency?
Thanks!
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Mar 13, 2024
jkoritzinsky added a commit that referenced this issue Mar 13, 2024
@jkoritzinsky
Use IntermediateAssembly instead of hard-coding the equivalent path
ccdae8e 
Fixes #99731
@jkoritzinsky jkoritzinsky mentioned this issue Mar 13, 2024
Merged
@jkoritzinsky jkoritzinsky added area-NativeAOT-coreclr and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 13, 2024
@jkoritzinsky jkoritzinsky added this to the 9.0.0 milestone Mar 13, 2024
jkoritzinsky added a commit that referenced this issue Mar 14, 2024
@jkoritzinsky
Use IntermediateAssembly instead of hard-coding the equivalent path (#…
fef9a5f 
…99732)

Fixes #99731
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Use IntermediateAssembly instead of hard-coding the equivalent path dotnet/runtime
2 participants
@jkoritzinsky @MrJul