Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] disable jiterp + enable safe points #100156

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[browser][MT] disable jiterp + enable safe points #100156

merged 2 commits into from
Mar 25, 2024

Conversation

pavelsavara
Copy link
Member

In hope that it will make #99888 go away

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Mar 22, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Mar 22, 2024
@pavelsavara pavelsavara requested a review from kg March 22, 2024 18:47
@pavelsavara pavelsavara self-assigned this Mar 22, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

This was referenced Mar 22, 2024
Closed
Closed
Closed
Open
Closed
Closed
@pavelsavara pavelsavara marked this pull request as ready for review March 25, 2024 12:36
@pavelsavara pavelsavara requested a review from maraf March 25, 2024 12:36
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara changed the title [browser][MT] disable jiterp [browser][MT] disable jiterp + enable safe points Mar 25, 2024
@pavelsavara
Copy link
Member Author

I filed #100237

This was referenced Mar 25, 2024
Closed
Open
Closed
@pavelsavara pavelsavara merged commit 1fecfbc into dotnet:main Mar 25, 2024
87 of 93 checks passed
@pavelsavara pavelsavara deleted the browser_mt_disable_jiterp branch March 25, 2024 17:30
@pavelsavara pavelsavara mentioned this pull request Mar 26, 2024
Closed
@pavelsavara
Copy link
Member Author

In hope that it will make #99888 go away

It didn't fix it. I created #100273 to enable it back in the future.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@kg kg kg approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @kg @maraf