-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VS install requirements to bump Windows 10 SDK version #100170
Update VS install requirements to bump Windows 10 SDK version #100170
Conversation
Tagging subscribers to this area: @dotnet/area-meta |
* **Desktop Development with C++** with all default components, plus: | ||
* *Windows 10 SDK (10.0.20348)* or newer, instead of version 10.0.19041 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **Desktop Development with C++** with all default components, plus: | |
* *Windows 10 SDK (10.0.20348)* or newer, instead of version 10.0.19041 | |
* **Desktop Development with C++** with all default components. |
This should not be necessary. I do not think that Desktop Development with C++ in Visual Studio 2022 17.8+ installs this several years old SDK by default. The SDK installed by Visual Studio 2022 17.8+ should be new enough for us. (I am not able check 17.8, but the default in 17.9 that I am on is 10.0.22621.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if my machine was picking up some old artifact then. I removed all VS installs from my machine and then chose to reinstall VS 2022 Preview and version 10.0.19041 was checked and the others weren't. I'll revert the changes to that file and keep just the change to .vsconfig
.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
As was discovered in #94106, our build now requires Windows 10 SDK 10.0.20348+. Using version 10.0.19041 results in the following build error when building mono.
I stumbled upon this while building clr+mono on a fresh machine. Updating the Windows 10 SDK version fixed my build.