Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang --version to get Apple toolset version #100190

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 23, 2024

Fixes #100189

Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@filipnavara filipnavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work both with and without Xcode.

We can switch to the JSON-based ld -version_details for more precise version detection if Apple fixes the new linker (new ld64 is >= 1000).

@VSadov
Copy link
Member

VSadov commented Mar 24, 2024

Looks good. My only concern is - are we sure the clang version changes in lockstep with xcode on MacOS?
Most likely. I am just not familiar with how they are versioned or whether can be acquired separately and not match.

Technically we just need to find that the clang/xcode is "new enough" to require classic loader switch. Hopefully this whole fallback scheme is temporary.

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

@jkotas jkotas merged commit 4e0d5d4 into dotnet:main Mar 24, 2024
90 checks passed
@jkotas jkotas deleted the xcode-version branch March 24, 2024 03:01
@jkotas
Copy link
Member Author

jkotas commented Mar 24, 2024

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8406851020

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xcode-select : error : tool 'xcodebuild' requires Xcode - new error with nativeaot in .NET 9 preview 2
3 participants