-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use clang --version to get Apple toolset version #100190
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work both with and without Xcode.
We can switch to the JSON-based ld -version_details
for more precise version detection if Apple fixes the new linker (new ld64 is >= 1000).
Looks good. My only concern is - are we sure the clang version changes in lockstep with xcode on MacOS? Technically we just need to find that the clang/xcode is "new enough" to require classic loader switch. Hopefully this whole fallback scheme is temporary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!!
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8406851020 |
Fixes #100189