[release/8.0-staging] Call the Copy Constructor for stack arguments in C++/CLI on x86 #100221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…86 (dotnet#100050) * Add repro test case * Directly load the argument address using ldarga to avoid making a copy * Reimplement the "Copy Constructor Cookie" logic in a more modern and maintainable style to get the test passing again * Narrow support to Windows only --------- Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
AaronRobinsonMSFT
added
Servicing-consider
jkotas
approved these changes
Mar 25, 2024
Sounds good. I wasn't sure how much effort we wanted to narrow the changes. I just tried applying them without a local build. If there is any fallout, I will look again tomorrow. |
This was referenced Mar 25, 2024
jeffschwMSFT
approved these changes
Mar 25, 2024
agocke
approved these changes
Mar 25, 2024
rbhanda
added
Servicing-approved
AaronRobinsonMSFT
merged commit ba9df1e
into
dotnet:release/8.0-staging
115 of 122 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #100050 to .NET 8.
/cc @jeffschwMSFT @agocke @jkotas
Customer Impact
See user reported issue #100033.
The workaround is to disable debug iterators or change the legacy code to avoid the problematic pattern. Both of these are unacceptable long-term in-production fixes.
Regression
Regression introduced from .NET Framework. Support was added in .NET Core 3.1 and included the regression - dotnet/coreclr#22805.
Testing
A test was added that validates the issue in a C++/CLI scenario.
Risk
Low