[release/8.0-staging] Support building against clang 18 #100258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a targeted backport from a few other PRs that makes it possible to build dotnet/runtme's 8.0 branch on Fedora 40 which includes clang 18. - dotnet/arcade#14572 - dotnet#94782 - dotnet#99811
dotnet-policy-service
bot
added
the
community-contribution
omajid
commented
Mar 25, 2024
| @@ -63,7 +63,7 @@ if [ -z "$CLR_CC" ]; then | |||
| # Set default versions | |||
| if [ -z "$majorVersion" ]; then | |||
| # note: gcc (all versions) and clang versions higher than 6 do not have minor version in file name, if it is zero. | |||
| if [ "$compiler" = "clang" ]; then versions="17 16 15 14 13 12 11 10 9 8 7 6.0 5.0 4.0 3.9 3.8 3.7 3.6 3.5" | |||
| if [ "$compiler" = "clang" ]; then versions="18 17 16 15 14 13 12 11 10 9 8 7 6.0 5.0 4.0 3.9 3.8 3.7 3.6 3.5" | |||
There was a problem hiding this comment.
Also submitted as dotnet/arcade#14650
jkotas
changed the title
jkotas
approved these changes
Mar 26, 2024
jeffschwMSFT
approved these changes
Mar 27, 2024
|
Fixes CI blocking #100215 |
|
@omajid Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
Build breaks when building with clang 18 (affects source build)
This is a targeted backport from a few other PRs that makes it possible to build dotnet/runtme's 8.0 branch on Fedora 40 which includes clang 18.
Regression
Testing
Verified by customer.
Risk
Low.