[browser] fix bit width from 32 to 8 for managed boolean #100304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
commented
Mar 26, 2024
| @@ -89,7 +89,7 @@ export function is_args_exception(args: JSMarshalerArguments): boolean { | |||
| export function is_receiver_should_free(args: JSMarshalerArguments): boolean { | |||
| if (!WasmEnableThreads) return false; | |||
| mono_assert(args, "Null args"); | |||
| return getB32(<any>args + JSMarshalerArgumentOffsets.ReceiverShouldFree); | |||
| return getB8(<any>args + JSMarshalerArgumentOffsets.ReceiverShouldFree); | |||
There was a problem hiding this comment.
I hope this is what causes #96546
kg
reviewed
Mar 26, 2024
kg
reviewed
Mar 26, 2024
kg
approved these changes
Mar 26, 2024
kg
reviewed
Mar 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.