-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAS tuning changes for small HCs #100390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maoni0
force-pushed
the
small_hc_checkin
branch
from
March 28, 2024 08:13
bec3f5b
to
00912f0
Compare
Tagging subscribers to this area: @dotnet/gc |
Maoni0
force-pushed
the
small_hc_checkin
branch
from
March 28, 2024 08:16
00912f0
to
e0f7ca2
Compare
I adjusted the formula for determining a new HC and change how we calculate the gen0 budget based on gen2 size.
mangod9
reviewed
Apr 2, 2024
mangod9
reviewed
Apr 2, 2024
mangod9
reviewed
Apr 2, 2024
mangod9
approved these changes
Apr 3, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
I adjusted the formula for determining a new HC and change how we calculate the gen0 budget based on gen2 size. changes included - + currently we have a very simplistic formula for actually adapting to the size and this basically just makes all the asp.net benchmarks with low surv rate adjust to the min 2.5 mb gen0 budget, while those run ok with such a small budget on a 28 core machine, it doesn't work if we limit the heap count to a small number, eg, 4. what happens is the % time in GC is very high, some benchmarks run with 20% to 40% time in GC. this is obviously not desirable. I reworked this to make it actually adapting to the size. and we'll take the min of this and what we calculated without DATAS. + the formula I had previously did not handle small HCs well so I also adjust that. + got rid of the adjusting to cache size in gc1 for DATAS, this just makes things unpredictable especially for small workloads.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes included -
and we'll take the min of this and what we calculated without DATAS.
the formula I had previously did not handle small HCs well so I also adjust that.
got rid of the adjusting to cache size in
gc1
for DATAS, this just makes things unpredictable especially for small workloads.I will add data for the final build soon. there's more work to do that I will address in future PRs -
conserve_mem_setting
into consideration.