-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] fix error propagation when calling JSImport of missing JS function #100408
Merged
pavelsavara
merged 4 commits into
dotnet:main
from
pavelsavara:browser_mt_missing_async_import
Apr 2, 2024
Merged
[browser][MT] fix error propagation when calling JSImport of missing JS function #100408
pavelsavara
merged 4 commits into
dotnet:main
from
pavelsavara:browser_mt_missing_async_import
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
labels
Mar 28, 2024
Tagging subscribers to 'arch-wasm': @lewing |
ilonatommy
approved these changes
Mar 28, 2024
mkhamoyan
approved these changes
Mar 28, 2024
maraf
approved these changes
Mar 28, 2024
/ba-g CI failures are known #100388 |
jakobbotsch
pushed a commit
to jakobbotsch/runtime
that referenced
this pull request
Apr 3, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in #100233
Will solve timeouts of
System.Runtime.InteropServices.JavaScript.Tests.JSImportTest.MissingImport
in #99888