[release/8.0-staging] Ensure that Sse3.MoveAndDuplicate correctly tracks supporting SIMD scalar loads #100417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
added
Servicing-consider
tannergooding
changed the title
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
tannergooding
added
area-CodeGen-coreclr
|
CC. @jakobbotsch since you reviewed and signed-off on the original fix. |
tannergooding
changed the title
|
CC. @JulieLeeMSFT, @jakobbotsch This is still pending sign-off for backport so it can goto tactics for approval. |
jakobbotsch
approved these changes
Apr 2, 2024
rbhanda
added
Servicing-approved
tannergooding
merged commit 7d45915
into
dotnet:release/8.0-staging
117 of 123 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #97783 to release/8.0-staging
/cc @tannergooding
Customer Impact
This was reported by a customer in #100404 and was internally found via #97688, where the containment checks around
Sse3.MoveAndDuplicateweren't sufficient and so we missed an opportunity that another code path (related to the AVX-512 embedded broadcast support) was assuming would be made.Regression
Prior to AVX-512 there was a missed containment opportunity, but this wasn't functionally incorrect, just less efficient. With the introduction of AVX-512 support in .NET 8, a new issue was introduced due to us missing the containment opportunity.
Testing
The fix was verified on the customer provided example in #100404 and a minimal regression test was added that validates the fix. The fix has been in .NET 9 for a couple months now with no additional issues having been found.
Risk
Low: This is a net new scenario in .NET 8 and only impacts customers with AVX-512 capable hardware.