Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT/x86] Add SAFESEH support to assembly files and ObjectWriter #100433

Merged
merged 6 commits into from
Mar 29, 2024
Merged

[NativeAOT/x86] Add SAFESEH support to assembly files and ObjectWriter #100433

merged 6 commits into from
Mar 29, 2024

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented Mar 29, 2024 •
edited
Loading

Fixes #100430

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 29, 2024
@filipnavara filipnavara marked this pull request as ready for review March 29, 2024 08:59
@filipnavara
Copy link
Member Author

filipnavara commented Mar 29, 2024 •
edited
Loading

I checked the "tree:nativeaot" subset of runtime tests with this and it still passes.

@jkotas jkotas mentioned this pull request Mar 29, 2024
Open
jkotas
jkotas approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit 34d13b2 into dotnet:main Mar 29, 2024
88 of 90 checks passed
@filipnavara filipnavara deleted the win-x86-safeseh branch March 29, 2024 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
arch-x86 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NativeAOT/x86] Enable SAFESEH
2 participants
@filipnavara @jkotas