Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all Cookie localized DateTime logic with Universal alternative #100489

Merged
merged 16 commits into from
Apr 24, 2024
Merged

Change all Cookie localized DateTime logic with Universal alternative #100489

merged 16 commits into from
Apr 24, 2024

Conversation

unknovvn
Copy link
Contributor

@unknovvn unknovvn commented Apr 1, 2024

Fix #95603

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 1, 2024
@unknovvn
Copy link
Contributor Author

unknovvn commented Apr 1, 2024

@dotnet-policy-service agree

@unknovvn unknovvn marked this pull request as ready for review April 1, 2024 16:58
@unknovvn unknovvn changed the title Change all localized DateTime logic with Universal alternative Change all Cookie localized DateTime logic with Universal alternative Apr 1, 2024
This was referenced Apr 1, 2024
Closed
Closed
This was referenced Apr 3, 2024
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 5, 2024
Closed
@ManickaP
Copy link
Member

ManickaP commented Apr 8, 2024

ping @dotnet/ncl

@ManickaP ManickaP self-requested a review April 9, 2024 15:56
@build-analysis build-analysis bot mentioned this pull request Apr 10, 2024
Closed
rzikm
rzikm approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment.

src/libraries/System.Net.Primitives/tests/FunctionalTests/CookieTest.cs Outdated Show resolved Hide resolved
@unknovvn @rzikm
Update src/libraries/System.Net.Primitives/tests/FunctionalTests/Cook…
9834bb1 
…ieTest.cs

Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>
@ManickaP
Copy link
Member

I think this line should be adjusted as well:

runtime/src/libraries/Common/src/System/Net/CookieParser.cs

Line 668 in d88c7ba

cookie!.Expires = DateTime.Now.AddSeconds(parsed);

Otherwise, LGTM. Thanks!

@unknovvn
Copy link
Contributor Author

I think this line should be adjusted as well:

runtime/src/libraries/Common/src/System/Net/CookieParser.cs

Line 668 in d88c7ba

cookie!.Expires = DateTime.Now.AddSeconds(parsed);

Otherwise, LGTM. Thanks!

Very good catch! Fix was already pushed. Thank you!

@build-analysis build-analysis bot mentioned this pull request Apr 10, 2024
Closed
@MihaZupan
Copy link
Member

Please don't "Update branch" unless you're making more changes as that causes the CI to restart every time

This was referenced Apr 10, 2024
Open
Open
This was referenced Apr 23, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ManickaP ManickaP merged commit 33e3f0c into dotnet:main Apr 24, 2024
78 of 87 checks passed
@build-analysis build-analysis bot mentioned this pull request Apr 24, 2024
Closed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@unknovvn @rzikm
@ManickaP @matouskozak
Change all Cookie localized DateTime logic with Universal alternative (…
254d160 
…dotnet#100489)

* Change all localized DateTime logic with Universal alternative

* tests adjusted

* comment updated according to changes

* Update src/libraries/System.Net.Primitives/tests/FunctionalTests/CookieTest.cs

Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>

* Code review comment fix

---------

Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
@build-analysis build-analysis bot mentioned this pull request May 2, 2024
Open
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@unknovvn @rzikm
@ManickaP @michaelgsharp
Change all Cookie localized DateTime logic with Universal alternative (…
595b900 
…dotnet#100489)

* Change all localized DateTime logic with Universal alternative

* tests adjusted

* comment updated according to changes

* Update src/libraries/System.Net.Primitives/tests/FunctionalTests/CookieTest.cs

Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>

* Code review comment fix

---------

Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@unknovvn @rzikm
@ManickaP @Ruihan-Yin
Change all Cookie localized DateTime logic with Universal alternative (…
4552b1d 
…dotnet#100489)

* Change all localized DateTime logic with Universal alternative

* tests adjusted

* comment updated according to changes

* Update src/libraries/System.Net.Primitives/tests/FunctionalTests/CookieTest.cs

Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>

* Code review comment fix

---------

Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzikm rzikm rzikm approved these changes

@ManickaP ManickaP ManickaP approved these changes

Assignees
No one assigned
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Cookie expiration uses local time instead of UTC
5 participants
@unknovvn @ManickaP @MihaZupan @rzikm @karelz