Allow for setting of isOfficialBuild when uploading intermediate artifacts #100528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng intermediate artifacts.
LoopedBard3
requested review from
sblom,
agocke,
jkoritzinsky,
DrewScoggins and
caaavik-msft
sblom
approved these changes
Apr 2, 2024
|
Is there a matching PR for the arcade repo? I assume that stuff in eng/common comes from there, and will get overwritten when we take an arcade update. |
|
I am assuming it will not get overwritten as PR that made the initial change was not an arcade update as far as I can tell, but if someone knows for sure, please weigh in. |
|
No, you are right. I didn't see it was eng/pipelines/common. |
jkoritzinsky
approved these changes
Apr 2, 2024
DrewScoggins
approved these changes
Apr 2, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…ng intermediate artifacts. (dotnet#100528)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for setting of isOfficialBuild when uploading intermediate artifacts.
After the update #99433, the performance pipeline runs started failing due to not being able to find
1ES.PublishBuildArtifacts, example run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2420076&view=results. This was due to theupload-intermediate-artifacts-stepsetting the job as an official build for the actual upload, where we use it as part of non-official builds. As such, I added the parameter isOfficialBuild with the default of true to allow for non-official build uses of the upload-intermediate-artifacts-step.yml.Test run showing that this fixes the yaml parsing error: https://dev.azure.com/dnceng/internal/_build/results?buildId=2420143&view=results