Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RuntimeHelpers.SizeOf #100618

Merged
merged 17 commits into from
Apr 9, 2024
Merged

Implement RuntimeHelpers.SizeOf #100618

merged 17 commits into from
Apr 9, 2024

Commits on Apr 3, 2024

  1. Implement RuntimeHelpers.SizeOf

    @jkoritzinsky
    jkoritzinsky committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3362c4a View commit details
    Browse the repository at this point in the history

  2. Add tests and add various fixes.

    @jkoritzinsky
    jkoritzinsky committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    47c6a24 View commit details
    Browse the repository at this point in the history

  3. PR feedback

    @jkoritzinsky
    jkoritzinsky committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    16ea830 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @jkoritzinsky @jkotas
    jkoritzinsky and jkotas authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    cb7ec92 View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System… 

    …/Runtime/CompilerServices/RuntimeHelpersTests.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @jkoritzinsky @jkotas
    jkoritzinsky and jkotas authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    47d3b54 View commit details
    Browse the repository at this point in the history

  3. Add more tests and throw for more invalid cases.

    @jkoritzinsky
    jkoritzinsky committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c086418 View commit details
    Browse the repository at this point in the history

  4. Generic parameter types don't have MethodTables in NativeAOT.

    @jkoritzinsky
    jkoritzinsky committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    84b4c0f View commit details
    Browse the repository at this point in the history

  5. Update src/coreclr/vm/reflectioninvocation.cpp

    @jkotas
    jkotas authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    49e6521 View commit details
    Browse the repository at this point in the history

  6. Fix CoreCLR

    @jkoritzinsky
    jkoritzinsky committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f93baee View commit details
    Browse the repository at this point in the history

  7. Separate out case to skip on NativeAOT as it's not relavant on the pl… 

    …atform
    @jkoritzinsky
    jkoritzinsky committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6898911 View commit details
    Browse the repository at this point in the history

  8. Check ContainsGenericVariables

    @jkoritzinsky
    jkoritzinsky committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    3423a52 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Update RuntimeHelpers.NativeAot.cs 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @jkoritzinsky @jkotas
    jkoritzinsky and jkotas authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1c473f6 View commit details
    Browse the repository at this point in the history

  2. Add doc comments

    @jkoritzinsky
    jkoritzinsky committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    21fde4e View commit details
    Browse the repository at this point in the history

  3. Separate out partially-specialized type test

    @jkoritzinsky
    jkoritzinsky committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    51a93b2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'sizeof' of github.com:jkoritzinsky/runtime into sizeof

    @jkoritzinsky
    jkoritzinsky committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ec81d77 View commit details
    Browse the repository at this point in the history

  5. Update doc comment to refer to Unsafe.SizeOf

    @jkoritzinsky
    jkoritzinsky committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ed05d1a View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Merge branch 'main' of github.com:dotnet/runtime into sizeof 

    # Conflicts:
#	src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
#	src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.NativeAot.cs
#	src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs
#	src/mono/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.Mono.cs
#	src/mono/mono/metadata/icall.c
    @jkoritzinsky
    jkoritzinsky committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    7908cf6 View commit details
    Browse the repository at this point in the history