Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] firefox testing #100697

Merged
merged 16 commits into from
Apr 25, 2024
Merged

[browser] firefox testing #100697

merged 16 commits into from
Apr 25, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 5, 2024 •
edited
Loading

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Apr 5, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 5, 2024
@pavelsavara pavelsavara self-assigned this Apr 5, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member Author

The geckodriver file does not exist in the current directory or in a directory on the PATH environment variable.
Log

Make DownloadAndInstallFirefox work

runtime/eng/testing/wasm-provisioning.targets

Line 181 in e1f5378

<Target Name="DownloadAndInstallFirefox"

This was referenced Apr 8, 2024
Closed
Closed
@pavelsavara
Copy link
Member Author

src\libraries\sendtohelix-browser.targets $HELIX_CORRELATION_PAYLOAD

This was referenced Apr 12, 2024
Closed
Open
Open
Open
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 15, 2024
Closed
This was referenced Apr 17, 2024
Closed
Closed
Open
Open
@pavelsavara pavelsavara mentioned this pull request Apr 17, 2024
Merged
This was referenced Apr 17, 2024
Closed
Closed
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

This was referenced Apr 23, 2024
Closed
Closed
Closed
Closed
Closed
@pavelsavara pavelsavara mentioned this pull request Apr 24, 2024
Open
@pavelsavara
Copy link
Member Author

Filled #101497

This was referenced Apr 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
maraf
maraf approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@maraf maraf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After offline discussion, all my suggestions are only about making things slightly more clean.
Postponing them at the moment to get this in

This was referenced Apr 25, 2024
Closed
Closed
@pavelsavara
Copy link
Member Author

/ba-g all issues are known

@pavelsavara pavelsavara merged commit d79bb01 into dotnet:main Apr 25, 2024
155 of 164 checks passed
@pavelsavara pavelsavara deleted the firefox_ci branch April 25, 2024 12:57
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pavelsavara @matouskozak
[browser] enable CI testing with Firefox (dotnet#100697)
bb970da
@build-analysis build-analysis bot mentioned this pull request May 2, 2024
Open
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@pavelsavara @michaelgsharp
[browser] enable CI testing with Firefox (dotnet#100697)
be9ec0b
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy left review comments

@maraf maraf maraf approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[browser][hybrid][firefox] RangeError: invalid value "Cyrl" for option region
3 participants
@pavelsavara @maraf @ilonatommy