-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify debug views of immutable dictionaries #100745
Merged
eiriktsarpalis
merged 3 commits into
dotnet:main
from
arturek:ImmutableDictionaryDebuggerTypeProxy
Jul 5, 2024
Merged
Unify debug views of immutable dictionaries #100745
eiriktsarpalis
merged 3 commits into
dotnet:main
from
arturek:ImmutableDictionaryDebuggerTypeProxy
Jul 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Apr 7, 2024
huoyaoyuan
reviewed
Apr 7, 2024
src/libraries/System.Private.CoreLib/src/System/Collections/Generic/IDictionaryDebugView.cs
Show resolved
Hide resolved
This was referenced Apr 15, 2024
Fixes dotnet#94289 - Updates the way the debugger displays the remaining dictionaries (Frozen, Immutable, ImmutableSorted, Concurrent) to present their keys and values in separate columns. - Fixes debugger views of Builder classes of immutable collections. Previous custom implementations incorrectly treated the Builder classes as immutable.
…ric dictionaries * Removed tests superseded by DebugView.Tests. * Fixed DebugView.Tests of cuncurrent and immutable generic dictionaries which failed on .Net Framework
eiriktsarpalis
force-pushed
the
ImmutableDictionaryDebuggerTypeProxy
branch
from
June 24, 2024 12:10
d722940
to
a3aa221
Compare
eiriktsarpalis
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This was referenced Jun 24, 2024
This was referenced Jun 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Collections
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94289