Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing RUC from Default and Ambient attributes #100821

Merged
merged 4 commits into from
Apr 13, 2024
Merged

Removing RUC from Default and Ambient attributes #100821

merged 4 commits into from
Apr 13, 2024

Conversation

LakshanF
Copy link
Member

@LakshanF LakshanF commented Apr 9, 2024

Missed removing the RUC when the feature switch is on with PR #100416

@LakshanF LakshanF self-assigned this Apr 9, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@LakshanF LakshanF requested a review from sbomer April 9, 2024 15:22
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 9, 2024
Closed
Open
Closed
Closed
Closed
This was referenced Apr 13, 2024
Closed
Closed
Closed
Closed
Closed
@LakshanF LakshanF merged commit 715e697 into dotnet:main Apr 13, 2024
163 of 165 checks passed
@LakshanF LakshanF deleted the DefaultValueFollowUp branch April 13, 2024 17:11
@build-analysis build-analysis bot mentioned this pull request Apr 13, 2024
Closed
@lewing lewing mentioned this pull request Apr 15, 2024
Merged
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@LakshanF @matouskozak
Removing RUC from Default and Ambient attributes (dotnet#100821)
897c5bd 
* Removing RUC from Default and Ambient attributes

* FB

* FB2
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbomer sbomer sbomer approved these changes

Assignees

@LakshanF LakshanF

Labels
area-System.ComponentModel new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LakshanF @sbomer