-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop generic type constraints from Unsafe.BitCast #100842
Drop generic type constraints from Unsafe.BitCast #100842
Conversation
Note regarding the
|
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices |
179ba2f
to
1210d9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
FYI @dotnet/jit-contrib (JIT-EE GUID changed) |
Sorry, I had thought jit-contrib had already been tagged above but now I see the area tag ended up being |
Another potentially related regression issue @MihaZupan |
* Drop generic type constraints from Unsafe.BitCast * Add isNullableType to JIT interface * superpmi * Comment formatting * Check IsGenericParameter instead of Canon * Replace IsGenericParameter check with assert * Just kidding, remove it completely :D
Fixes #99205
Fixes #99006
MihuBot/runtime-utils#354
Most diffs appear to be more inlining / removing unreachable branches. For example seeing that these
IndexOf*
calls are passing in 0 and therefore deleting the checks and unreachable calls toPackedSpanHelpers
runtime/src/libraries/System.Net.Http/src/System/Net/Http/Headers/UriHeaderParser.cs
Lines 65 to 67 in 3462976
Part of the diff