Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable COM descriptor support when trimming #100881

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Apr 10, 2024

Companion to the SDK change in dotnet/sdk#40106

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 10, 2024
@sbomer sbomer marked this pull request as ready for review April 10, 2024 17:42
@sbomer sbomer requested a review from LakshanF April 10, 2024 17:42
Copy link
Member

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this on the first CR.

@sbomer sbomer merged commit 4a01602 into dotnet:main Apr 10, 2024
77 of 81 checks passed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
Defaults the COM type descriptor feature switch to false in trimmed apps.
Depends on the SDK change dotnet/sdk#40106.
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants