Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArgumentNullException in SecurityIdentifier.CompareTo(null) #101002

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix ArgumentNullException in SecurityIdentifier.CompareTo(null) #101002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/System.Security.Principal.Windows/src/System/Security/Principal/SID.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,10 @@ public override IdentityReference Translate(Type targetType)

public int CompareTo(SecurityIdentifier? sid)
{
ArgumentNullException.ThrowIfNull(sid);
if (sid is null)
{
return 1;
}

if (this.IdentifierAuthority < sid.IdentifierAuthority)
{
Expand Down
11 changes: 11 additions & 0 deletions src/libraries/System.Security.Principal.Windows/tests/WellKnownSidTypeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,4 +152,15 @@ public void MaxDefinedHasLegacyValue()
Assert.Equal(WellKnownSidType.WinBuiltinTerminalServerLicenseServersSid, WellKnownSidType.MaxDefined);
#pragma warning restore 0618
}

[ConditionalTheory(nameof(AccountIsDomainJoined))]
[InlineData(WellKnownSidType.WorldSid)]
public void CompareTo_Null(WellKnownSidType sidType)
{
using (var identity = WindowsIdentity.GetCurrent())
{
var si = new SecurityIdentifier(sidType, identity.Owner.AccountDomainSid);
Assert.Equal(1, si.CompareTo(null));
}
}
}
Loading