Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for containing RotateLeft/RotateRight on Arm64 #101030

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Add support for containing RotateLeft/RotateRight on Arm64 #101030

merged 5 commits into from
Apr 15, 2024

Conversation

tannergooding
Copy link
Member

This resolves #101027

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 14, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tannergooding tannergooding marked this pull request as ready for review April 15, 2024 06:54
@tannergooding
Copy link
Member Author

Some decent diffs with no TP impact for the x ^ rotate(y, cns) pattern: https://dev.azure.com/dnceng-public/public/_build/results?buildId=643031&view=ms.vss-build-web.run-extensions-tab

-11,540 on Linux Arm64, with about 25% of that in PGO benchmarks

CC. @dotnet/jit-contrib, @EgorBo this should be ready for review.

EgorBo
EgorBo approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tannergooding
Copy link
Member Author

tannergooding commented Apr 15, 2024 •
edited
Loading

hmmm, there is an SPMI replay failure. But it's in hwintrinsiccodegenarm64.cpp for DecodeFromUtf8 (which was updated over the weekend): #100589

I think it's likely unrelated to this PR, but I'll investigate and make sure an issue is opened before merging.

@tannergooding
Copy link
Member Author

Opened #101070, it is asserting without this PR and in other CI legs.

@tannergooding tannergooding merged commit 3d0da2c into dotnet:main Apr 15, 2024
108 of 110 checks passed
@tannergooding tannergooding deleted the fix-101027 branch April 15, 2024 17:49
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@tannergooding @matouskozak
Add support for containing RotateLeft/RotateRight on Arm64 (dotnet#10…
bae5a06 
…1030)

* Add support for containing RotateLeft/RotateRight on Arm64

* Fix a variable name

* Applying formatting patch

* Ensure lsrabuild handles contained GT_ROR

* Ensure codegenlinear can consume contained GT_ROR
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@tannergooding tannergooding

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arm64: ror+eor -> eor, ror
2 participants
@tannergooding @EgorBo