Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globbing - Use GetFullPath for normalization on relative files #101083

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Globbing - Use GetFullPath for normalization on relative files #101083

merged 1 commit into from
Apr 16, 2024

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Apr 15, 2024

Fixes #100762.

For context:

What's causing file (in matcher.Match("./sdk/9.0.100-preview.4.24207.1/.version") to not match is the leading ./. I excluded relative paths from using GetFullPath (In #94528) in order to decouple them from CWD. However, GetFullPath should still be used on relative paths (combined with rootDir, instead of CWD) so normalization provided by GetFullPath can remove those redundant segments, which are not accounted for in subsequent code.

@jozkee jozkee added this to the 9.0.0 milestone Apr 15, 2024
@jozkee jozkee self-assigned this Apr 15, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-filesystem
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 16, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ViktorHofer ViktorHofer merged commit 9d88225 into dotnet:main Apr 16, 2024
83 of 87 checks passed
@jozkee jozkee deleted the globbing-file-redundant-segments branch April 16, 2024 15:19
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@jozkee @matouskozak
Use GetFullPath for normalization on relative files (dotnet#101083)
f5644ac
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley

Assignees

@jozkee jozkee

Labels
area-Extensions-FileSystem
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Matcher.Match(string) regression between 8.0.0 and 9.0.0 Preview 1
2 participants
@jozkee @ViktorHofer