JIT: Use likelihoods in block reordering decision #101132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
AndyAyersMS
reviewed
Apr 17, 2024
src/coreclr/jit/fgopt.cpp
Outdated
| // the branch | ||
| if (takenCount < (0.51 * totalCount)) | ||
| // If we take the true branch more than half the time, we will reverse the branch. | ||
| if (edgeToDest->getLikelihood() < 0.51) |
There was a problem hiding this comment.
Can we rename these edge vars? Something like trueEdge / falseEdge? There are some mentions up in the comment and vestiges of the old min/max there too.
Also down below this a bit, subtracting 1 is not semantically meaningful. However perhaps we should leave this for now as this logic will ultimately not be needed when we do the new block layout.
AndyAyersMS
approved these changes
Apr 17, 2024
|
Forgot to mention this, but no diffs. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #99736. This should be a no-diff change.