Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] rename WasmTestOnChrome #101140

Merged
merged 6 commits into from
Apr 18, 2024
Merged

[browser] rename WasmTestOnChrome #101140

merged 6 commits into from
Apr 18, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 16, 2024 •
edited
Loading

  • WasmTestOnBrowser -> WasmTestOnChrome
  • normal -> WasmTestOnWasmtime
  • BROWSER_PATH_FOR_TESTS -> CHROME_PATH_FOR_TESTS or FIREFOX_PATH_FOR_TESTS
  • _WasmBrowserPathForTests -> _WasmChromePathForTests or _WasmFirefoxPathForTests
  • drop WasmRunnerAOTTemplate.sh and move _buildAOTFunc() to WasmRunnerTemplate.sh
  • drop WasiRunnerAOTTemplate.sh and move _buildAOTFunc() to WasiRunnerTemplate.sh
  • added $(TestArchiveRoot)chromeonly
  • added $(TestArchiveRoot)wasmtimeonly
  • renamed ChromeVersions.props -> BrowserVersions.props

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 17, 2024
Closed
Closed
@pavelsavara pavelsavara marked this pull request as ready for review April 17, 2024 11:05
ilonatommy
ilonatommy approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

pavelsavara and others added 3 commits April 17, 2024 14:40
@pavelsavara @maraf
Update eng/pipelines/common/templates/wasm-library-aot-tests.yml
c8797a6 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara
Merge branch 'main' into WasmTestOnChrome
f9045bd 
# Conflicts:
#	eng/testing/tests.browser.targets
#	src/libraries/sendtohelix-browser.targets
#	src/mono/wasm/Wasm.Build.Tests/Common/EnvironmentVariables.cs
#	src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj
@pavelsavara
BrowserVersions.props
e5babd7
This was referenced Apr 17, 2024
Closed
Closed
This was referenced Apr 17, 2024
Closed
Closed
Open
@lewing lewing mentioned this pull request Apr 17, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 17, 2024
Open
@pavelsavara
Copy link
Member Author

/ba-g CI failures are known

@pavelsavara pavelsavara merged commit 9068070 into dotnet:main Apr 18, 2024
162 of 168 checks passed
@pavelsavara pavelsavara deleted the WasmTestOnChrome branch April 18, 2024 07:52
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pavelsavara @maraf @matouskozak
[browser] rename WasmTestOnChrome (dotnet#101140)
9df7336 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@maraf maraf maraf left review comments

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

Assignees

@pavelsavara pavelsavara

Labels
area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @maraf @ilonatommy