Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Integrate static web asset endpoints into wasm sdk #101315

Merged
merged 2 commits into from
May 7, 2024

Conversation

javiercn
Copy link
Member

No description provided.

@javiercn javiercn force-pushed the javiercn/integrate-static-web-asset-endpoints branch from 68597ac to 12fccfa Compare April 20, 2024 05:21
@maraf maraf added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Apr 22, 2024
@maraf maraf added this to the 9.0.0 milestone Apr 22, 2024
@maraf maraf changed the title [Wasm] Integrate static web asset endpoints into wasm sdk [browser] Integrate static web asset endpoints into wasm sdk Apr 22, 2024
@maraf maraf self-requested a review April 22, 2024 14:23
@javiercn javiercn force-pushed the javiercn/integrate-static-web-asset-endpoints branch 2 times, most recently from c749170 to c3d96ad Compare May 6, 2024 20:25
@javiercn javiercn marked this pull request as ready for review May 6, 2024 20:28
@javiercn javiercn force-pushed the javiercn/integrate-static-web-asset-endpoints branch from c3d96ad to 901df83 Compare May 7, 2024 06:46
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -511,7 +556,7 @@ Copyright (c) .NET Foundation. All rights reserved.
</ItemGroup>
</Target>

<Target Name="_AddPublishWasmBootJsonToStaticWebAssets">
<Target Name="_AddPublishWasmBootJsonToStaticWebAssets" DependsOnTargets="GeneratePublishWasmBootJson">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GeneratePublishWasmBootJson can be removed from ResolveCompressedFilesForPublishDependsOn now

@javiercn javiercn merged commit a9f43da into main May 7, 2024
23 checks passed
@javiercn javiercn deleted the javiercn/integrate-static-web-asset-endpoints branch May 7, 2024 09:27
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
…101315)

* Integrate static web asset endpoints
---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
…101315)

* Integrate static web asset endpoints
---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants