Disable most of S.T.Json trimming tests on AOT the right way #101418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These don't seem to use the source generator, so they're not really "trimming tests" and obviously they don't work. The underlying issue to fix them up has been closed.
MichalStrehovsky
changed the title
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
This was referenced Apr 23, 2024
This was referenced Apr 24, 2024
Closed
eerhardt
reviewed
Apr 24, 2024
| @@ -1,7 +1,9 @@ | |||
| <Project DefaultTargets="Build"> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" /> | |||
|
|
|||
| <ItemGroup> | |||
| <!-- These tests need to be rewritten to use source generator: https://github.com/dotnet/runtime/issues/53437, | |||
There was a problem hiding this comment.
This issue is closed. Can we either reopen it or open a new one?
There was a problem hiding this comment.
Reopened #53437 but per my experience, something in Future milestone is usually as good as closed
There was a problem hiding this comment.
Agreed. But it is bad to link a tracking comment to a closed issue. If we aren't going to fix the issue, we should remove/reword the comment.
eerhardt
approved these changes
Apr 24, 2024
This was referenced Apr 25, 2024
Closed
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…101418) These don't seem to use the source generator, so they're not really "trimming tests" and obviously they don't work.
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…101418) These don't seem to use the source generator, so they're not really "trimming tests" and obviously they don't work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These don't seem to use the source generator, so they're not really "trimming tests" and obviously they don't work. The underlying issue to fix them up has been closed.