Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for boxing byreflike fail. #101458

Merged
merged 4 commits into from
Apr 25, 2024
+85 −0
Merged

Add test for boxing byreflike fail. #101458

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71f2f51
Add test for boxing byreflike fail.
AaronRobinsonMSFT Apr 23, 2024
f90be4b
Check if type is compatible right before emitting box
fanyang-mono Apr 24, 2024
0c81c93
Add test for using byreflike type in isinst expressions.
AaronRobinsonMSFT Apr 24, 2024
5868491
Merge remote-tracking branch 'upstream/main' into tests_byreflike_box…
AaronRobinsonMSFT Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions src/tests/Loader/classloader/generics/ByRefLike/InvalidCSharp.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,41 @@
ret
}

.method public hidebysig
instance bool BoxBranchToOther<byreflike U>(!T) cil managed
{
ldarg.1
// Begin sequence
box !!U
brfalse.s NEXT_1
// End sequence
NEXT_1:

ldarg.1
// Begin sequence
box !!U
brfalse NEXT_2
// End sequence
NEXT_2:

ldarg.1
// Begin sequence
box !!U
brtrue.s NEXT_3
// End sequence
NEXT_3:

ldarg.1
// Begin sequence
box !!U
brtrue NEXT_4
// End sequence
NEXT_4:

ldc.i4.1
ret
}

.method public hidebysig
instance bool BoxBranch_WithSideEffects(!T&) cil managed
{
Expand Down Expand Up @@ -284,6 +319,26 @@
ret
}

.method public hidebysig
instance bool BoxIsinstBranch_UsingTypeConstraints<byreflike (InvalidCSharp.EmptyInterface) U>(class InvalidCSharp.EmptyInterface) cil managed
{
.locals init (
[0] !!U
)
ldarg.1
isinst !!U
brfalse.s NOT_U
ldarg.1
isinst !!U
unbox.any !!U
stloc.0
ldc.i4.0
ret
NOT_U:
ldc.i4.1
ret
}

.method public hidebysig
instance bool AllocArrayOfT() cil managed aggressiveinlining
{
Expand Down Expand Up @@ -406,6 +461,19 @@
{
}

.class public auto ansi beforefieldinit InvalidCSharp.ClassWithInterface
extends [System.Runtime]System.Object
implements InvalidCSharp.EmptyInterface
{
.method public hidebysig specialname rtspecialname
instance void .ctor () cil managed
{
ldarg.0
call instance void [System.Runtime]System.Object::.ctor()
ret
}
}

// Generic substitution of allow-byreflike with allow-byreflike
.class interface public auto ansi abstract InvalidCSharp.GenericDerivedInterface_OverByRef`1<byreflike T>
implements class InvalidCSharp.GenericInterface_Over`1<!T>
Expand Down Expand Up @@ -651,6 +719,18 @@
call instance bool valuetype InvalidCSharp.GenericByRefLike_Over`1<valuetype ByRefLikeType>::BoxBranch(!0)
pop

ldloca.s 0
ldloc 0
ldfld !0 valuetype InvalidCSharp.GenericByRefLike_Over`1<valuetype ByRefLikeType>::Field
call instance bool valuetype InvalidCSharp.GenericByRefLike_Over`1<valuetype ByRefLikeType>::BoxBranchToOther<valuetype InvalidCSharp.ByRefLikeTypeWithInterface>(!0)
pop

ldloca.s 0
ldloc 0
ldfld !0 valuetype InvalidCSharp.GenericByRefLike_Over`1<valuetype ByRefLikeType>::Field
call instance bool valuetype InvalidCSharp.GenericByRefLike_Over`1<valuetype ByRefLikeType>::BoxBranchToOther<valuetype RegularValueType>(!0)
pop

ldloca.s 0
ldloca.s 0
ldflda !0 valuetype InvalidCSharp.GenericByRefLike_Over`1<valuetype ByRefLikeType>::Field
Expand Down Expand Up @@ -695,6 +775,11 @@
ldloca.s 0
ldflda !0 valuetype InvalidCSharp.GenericByRefLike_Over`1<valuetype ByRefLikeType>::Field
call instance bool valuetype InvalidCSharp.GenericByRefLike_Over`1<valuetype ByRefLikeType>::BoxIsinstBranch_WithSideEffects(!0&)
pop

ldloca.s 0
newobj instance void InvalidCSharp.ClassWithInterface::.ctor()
call instance bool valuetype InvalidCSharp.GenericByRefLike_Over`1<valuetype ByRefLikeType>::BoxIsinstBranch_UsingTypeConstraints<valuetype InvalidCSharp.ByRefLikeTypeWithInterface>(class InvalidCSharp.EmptyInterface)

ret
}
Expand Down