-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor AdvSimd version of DecodeFromUTF8 #101620
Refactor AdvSimd version of DecodeFromUTF8 #101620
Conversation
SwapnilGaikwad
commented
Apr 26, 2024
- Add more comments to describe the decode algorithm
- Addresses comments from Use multi-reg load/store for DecodeFromUTF8 #100589
@a74nh @kunalspathak @dotnet/arm64-contrib |
There is no notable performance difference on a V1 and N1 system for this patch. Assembly sequence for DecodeFromUtf8
|
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Show resolved
Hide resolved
Tagging subscribers to this area: @dotnet/area-system-buffers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some questions/comments.
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* Refactor AdvSimd version of DecodeFromUTF8 * Refactor look-up table for readability * Fix the comments